Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset ForceLogout component upon relogin #640

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
ForceLogout component reset incomplete.

Description of changes:
Applying MobX observables for resetting ForceLogout upon login.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 SanketD92 requested a review from a team as a code owner August 6, 2021 18:19
@github-actions github-actions bot added the size/s label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #640 (5d9725d) into develop (01a87b1) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5d9725d differs from pull request most recent head 872e612. Consider uploading reports for the commit 872e612 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #640      +/-   ##
===========================================
- Coverage    49.21%   49.20%   -0.02%     
===========================================
  Files          246      246              
  Lines        12658    12665       +7     
  Branches      2022     2023       +1     
===========================================
+ Hits          6230     6232       +2     
- Misses        5625     5629       +4     
- Partials       803      804       +1     
Impacted Files Coverage Δ
src/parts/ForceLogout.js 53.19% <0.00%> (-4.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a87b1...872e612. Read the comment docs.

nguyen102
nguyen102 previously approved these changes Aug 6, 2021
@SanketD92 SanketD92 merged commit 5c2aaee into develop Aug 9, 2021
@SanketD92 SanketD92 deleted the fix-mobx-component-reset branch August 9, 2021 20:35
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
* fix: reset ForceLogout component upon relogin

* fix: enter intervalId for clearInterval call

* Trigger notification

* fix: update clearInterval call in unit test

* fix: clear IntervalId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants