Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency fix #653

Merged
merged 3 commits into from
Aug 12, 2021
Merged

chore: dependency fix #653

merged 3 commits into from
Aug 12, 2021

Conversation

Bingjiling
Copy link
Contributor

Issue #, if available:

Description of changes:

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #653 (5afa97c) into develop (4c21a30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #653   +/-   ##
========================================
  Coverage    49.20%   49.20%           
========================================
  Files          246      246           
  Lines        12665    12665           
  Branches      2023     2023           
========================================
  Hits          6232     6232           
  Misses        5629     5629           
  Partials       804      804           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c21a30...5afa97c. Read the comment docs.

@Bingjiling Bingjiling merged commit b6d1dcf into develop Aug 12, 2021
@Bingjiling Bingjiling deleted the path-parse-fix branch August 12, 2021 20:52
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants