Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no sagemaker autostop lag #703

Merged
merged 6 commits into from
Sep 10, 2021
Merged

fix: no sagemaker autostop lag #703

merged 6 commits into from
Sep 10, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available: GALI-965

Description of changes: Reduces lag of Sagemaker instances showing up as available when they have autostopped or are autostopping to a few seconds from a few minutes (or infinity in some cases)

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #703 (85e481e) into develop (118c957) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 85e481e differs from pull request most recent head 2fc21b3. Consider uploading reports for the commit 2fc21b3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #703   +/-   ##
========================================
  Coverage    49.16%   49.17%           
========================================
  Files          252      252           
  Lines        12799    12800    +1     
  Branches      2062     2061    -1     
========================================
+ Hits          6293     6294    +1     
  Misses        5692     5692           
  Partials       814      814           
Impacted Files Coverage Δ
...ironment/service-catalog/environment-sc-service.js 71.32% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118c957...2fc21b3. Read the comment docs.

@github-actions github-actions bot added size/m and removed size/s labels Sep 10, 2021
@maghirardelli maghirardelli merged commit 8cb199b into develop Sep 10, 2021
@maghirardelli maghirardelli deleted the autostopbug branch September 10, 2021 18:33
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants