Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add coverage for undef config case #761

Merged
merged 4 commits into from
Oct 19, 2021
Merged

fix: add coverage for undef config case #761

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad0ae27
fix: add coverage for undef config case
maghirardelli Oct 18, 2021
f28b8dd
Merge branch 'develop' into undef-config-unit-tests
maghirardelli Oct 18, 2021
fcba38d
clean tests
maghirardelli Oct 18, 2021
85d857d
Merge branch 'undef-config-unit-tests' of https://github.com/awslabs/…
maghirardelli Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions ...as-ui/packages/base-raas-ui/src/parts/environments-sc/__tests__/ScEnvironmentCard.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const scEnvironment = {
rev: 2,
status: 'active',
description: 'sample description',
envTypeConfigId: 'env type config id',
envTypeConfigId: 'existingConfigId',
name: 'name',
projectId: 'project id',
envTypeId: 'env type id',
Expand All @@ -51,10 +51,15 @@ const scEnvironment = {
outputs: [],
};

const scEnvConfig = {
name: 'name',
instanceType: 'instanceType',
};

const envTypesStore = {
getEnvTypeConfigsStore: jest.fn(() => envTypesStore),
load: jest.fn(),
getEnvTypeConfig: jest.fn(),
getEnvTypeConfig: jest.fn(envTypeConfigId => (envTypeConfigId === 'existingConfigId' ? scEnvConfig : undefined)),
};

describe('ScEnvironmentCard', () => {
Expand Down Expand Up @@ -86,10 +91,26 @@ describe('ScEnvironmentCard', () => {
const spyOnConfigsStore = jest.spyOn(component, 'getEnvTypeConfigsStore');

// OPERATE
component.getConfiguration(scEnvironment.envTypeConfigId);
const config = component.getConfiguration(scEnvironment.envTypeConfigId);

// CHECK
expect(spyOnConfigsStore).toHaveBeenCalled();
expect(envTypesStore.getEnvTypeConfig).toHaveBeenCalledWith(scEnvironment.envTypeConfigId);
expect(config.name).toBeDefined();
expect(config.instanceType).toBeDefined();
expect(config).toEqual(scEnvConfig);
});

it('should get undefined configuration', async () => {
// BUILD
const spyOnConfigsStore = jest.spyOn(component, 'getEnvTypeConfigsStore');

// OPERATE
const config = component.getConfiguration('deletedConfigId');

// CHECK
expect(spyOnConfigsStore).toHaveBeenCalled();
expect(envTypesStore.getEnvTypeConfig).toHaveBeenCalledWith('deletedConfigId');
expect(config).toBeUndefined();
});
});