Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AppDeployer needs perms to create new env #762

Merged
merged 5 commits into from
Oct 19, 2021
Merged

fix: AppDeployer needs perms to create new env #762

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e22a52
fix: AppDeployer needs perms to create new env
SanketD92 Oct 18, 2021
7c5d0da
fix: AppDeployer specific changes only
SanketD92 Oct 18, 2021
adfb8da
Merge branch 'fix-cicd-appdeployer-role' of https://github.com/awslab…
SanketD92 Oct 18, 2021
a6f6849
removing unrelated changes
SanketD92 Oct 18, 2021
7462872
Merge branch 'develop' into fix-cicd-appdeployer-role
SanketD92 Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions main/cicd/cicd-pipeline/config/infra/cloudformation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ Resources:
Type: AWS::SNS::Topic
Properties: !If
- SubscribeNotificationEmail
-
Subscription:
- Subscription:
- Endpoint: ${self:custom.settings.emailForNotifications}
Protocol: email
KmsMasterKeyId: alias/aws/sns
Expand Down Expand Up @@ -229,7 +228,7 @@ Resources:
- Action:
- iam:PassRole
Effect: Allow
Resource: !Sub 'arn:aws:iam::${AWS::AccountId}:role/${self:custom.settings.namespace}-cicd-pipeline-AppDeployerRole-*'
Resource: !Sub 'arn:aws:iam::${AWS::AccountId}:role/${self:custom.settings.namespace}-*'
- Action:
- iam:CreatePolicy
- iam:GetPolicy
Expand Down