Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create aws account exc #895

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
V377389564

Description of changes:
Catch errors from S3 bucket policy update logic to only display error code instead of entire stack trace.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #895 (9dc0608) into develop (8ba8e8b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #895   +/-   ##
========================================
  Coverage    51.13%   51.14%           
========================================
  Files          292      292           
  Lines        16424    16427    +3     
  Branches      2548     2547    -1     
========================================
+ Hits          8398     8401    +3     
  Misses        7054     7054           
  Partials       972      972           
Impacted Files Coverage Δ
lib/aws-accounts/aws-accounts-service.js 75.00% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba8e8b...9dc0608. Read the comment docs.

Copy link
Contributor

@maghirardelli maghirardelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@SanketD92 SanketD92 merged commit 85ae1e2 into develop Feb 1, 2022
@SanketD92 SanketD92 deleted the fix-create-aws-account-exc branch February 1, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants