-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Throw HTTP Status 429 error when there are too many get Sagemaker Presigned URL requests #942
fix: Throw HTTP Status 429 error when there are too many get Sagemaker Presigned URL requests #942
Conversation
…r Presigned URL requests
Codecov Report
@@ Coverage Diff @@
## develop #942 +/- ##
===========================================
+ Coverage 51.45% 51.47% +0.01%
===========================================
Files 295 295
Lines 16790 16795 +5
Branches 2598 2600 +2
===========================================
+ Hits 8640 8645 +5
Misses 7163 7163
Partials 987 987
Continue to review full report at Codecov.
|
…rvice-workbench-on-aws into sagemaker-too-many-requests
} | ||
}); | ||
throw e; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we throwing the stack trace itself? Rather could we throw a boom error with just the e.code
if required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line will rethrow what was already thrown. In the code, it looks like that will be boom
errors. That means there won't be a stack trace.
Issue #, if available:
Description of changes:
When multiple requests are made to retrieve a Sagemaker URL, we can not process more than one request at a time.
We'll now throw a HTTP Status Code 429 error, with the following body
Before the fix this was what we returned
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.