fix: don't sign Expect header in SigV4 #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
lauzadis
approved these changes
Feb 27, 2023
lucix-aws
approved these changes
Feb 28, 2023
aajtodd
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes aws-sdk-kotlin#862
Description of changes
Recent changes #802 and aws-sdk-kotlin#845 enabled sending the
Expect: 100-continueheader on S3 PUT requests over 2MB (by default). TheExpectheader is not meant to be signed and causes a problem when using S3 with Transfer Acceleration enabled. (It is unknown why this doesn't also cause a problem when using the default S3 configuration.)This change exempts the
Expectheader from signature calculation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.