Add missing dependency of @smithy/shared-ini-file-loader #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Oct 12, 2023
syall
approved these changes
Oct 12, 2023
hpmellema
pushed a commit
to hpmellema/smithy-typescript
that referenced
this pull request
Nov 1, 2023
…-lang#1027) * fix(smithy-client): string.toString requires this be a String Because of Because of microsoft/tslib#95, TS 'extends' shim doesn't support extending native types like String. So here we create StringWrapper that duplicate everything from String class including its prototype chain. So we can extend from here. * fix: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
@smithy/middleware-endpointmissing dep on@smithy/shared-ini-file-loader#1019Description of changes:
Add missing dependency of @smithy/shared-ini-file-loader
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.