Update README #1057
Merged
Update README #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
update-readme
branch
4 times, most recently
from
b126bd3
to
1ac660c
Compare
syall
force-pushed
the
update-readme
branch
2 times, most recently
from
c2ccf33
to
0086542
Compare
syall
force-pushed
the
update-readme
branch
5 times, most recently
from
bde0e39
to
85b4deb
Compare
hpmellema
requested changes
Nov 3, 2023
| ```kotlin | ||
| plugins { | ||
| id("java-library") | ||
| id("software.amazon.smithy.gradle.smithy-jar").version("0.8.0") |
There was a problem hiding this comment.
I think we just need the smithy-base plugin here b/c we dont actually care about the generated jar.
There was a problem hiding this comment.
This was from the quickstart-gradle template, so I don't think it makes sense to go into that much detail for a quick start.
There was a problem hiding this comment.
We should make sure when we add the new example templates for this repo they use the correct plugin. This one is not correct for this use case.
hpmellema
reviewed
Nov 3, 2023
syall
force-pushed
the
update-readme
branch
4 times, most recently
from
a43a165
to
e3eb40f
Compare
hpmellema
reviewed
Nov 3, 2023
...n/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptClientCodegenPlugin.java
Show resolved
Hide resolved
hpmellema
approved these changes
Nov 3, 2023
trivikr
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Update README with:
And other quality of life fixes.
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.