fix: use optional chaining while processing runtime config #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
approved these changes
Aug 20, 2021
Using default value of `{}` assumed that client configs have no
required properties, which may not be true for generic non-AWS clients
where endpoint may be required.
Using `?.` operator for cases where `config` may be null/undefined.
gosar
force-pushed
the
runtimeconfig-chaining
branch
from
c2db246
to
10a5199
Compare
gosar
changed the title
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate solution to #391 that works for generic clients too.
Using default value of
{}assumed that client configs have norequired properties, which may not be true for generic non-AWS clients
where endpoint may be required.
Using
?.operator for cases whereconfigmay be null/undefined.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.