feat: remove comments from transpiled JS files #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
clients-tsconfig-types
branch
from
d8d629c
to
0582b5d
Compare
AllanZhengYP
approved these changes
Sep 24, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* chore: create tsconfig.types.json as copy of tsconfig.es.json * chore: add tsconfig.types.json in static file copies * chore: generate types in tsconfig.types.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Refs: aws/aws-sdk-js-v3#2797
Experimental PR in trivikr/temp-client-s3#9
Description of changes:
Removes comments from transpiled JS files as follows:
removeComments: truefor CJS and ES TSConfigs, and removes config to emit declaration files.tsconfig.types.jsonfor emitting declaration files.build:typesscript for generating types, and calls it frombuild.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.