feat(smithy-typescript-codegen): allow deferred resolution for api key config #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
reviewed
Sep 30, 2022
...main/java/software/amazon/smithy/typescript/codegen/integration/AddHttpApiKeyAuthPlugin.java
Show resolved
Hide resolved
eduardomourar
changed the title
eduardomourar
changed the title
gosar
reviewed
Sep 30, 2022
...rc/main/resources/software/amazon/smithy/typescript/codegen/integration/http-api-key-auth.ts
Show resolved
Hide resolved
gosar
approved these changes
Oct 1, 2022
kuhe
approved these changes
Oct 1, 2022
eduardomourar
force-pushed
the
fix/dependency-api-key-middleware
branch
from
c00e4a0
to
5147e54
Compare
milesziemer
pushed a commit
to milesziemer/smithy-typescript
that referenced
this pull request
Dec 14, 2022
…y config (smithy-lang#588) Co-authored-by: Eduardo Rodrigues <eduardomourar@users.noreply.github.com>
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
…y config (smithy-lang#588) Co-authored-by: Eduardo Rodrigues <eduardomourar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
In order to defer resolving the API Key configuration to when we actually make the API call, we need to allow a function to be passed in the
apiKeyproperty. Now that we are importing the library@aws-sdk/util-middlewareas part of the API Key middleware, we included it explicitly as a dependency to our generated project.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.