fix(endpoint): fixes to endpoints codegen from user testing #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kuhe
commented
Sep 21, 2022
kuhe
commented
- codegen fixes for endpoints 2.0
kuhe
commented
Sep 21, 2022
| @@ -201,13 +202,14 @@ private void generateEndpointParameterInstructionProvider() { | |||
| name, EndpointsParamNameMap.getLocalName(name) | |||
| ); | |||
| }); | |||
| parameterFinder.getStaticContextParamValues(operation).forEach((name, value) -> { | |||
| Shape operationInput = model.getShape(operation.getInputShape()).get(); | |||
There was a problem hiding this comment.
fix: the contextParams are traits on input structure members, not the operation itself
...rc/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/EndpointsV2Generator.java
Outdated
Show resolved
Hide resolved
trivikr
approved these changes
Sep 21, 2022
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
…ang#592) * fix(endpoint): fixes to endpoints codegen from user testing * feat(endpoint): check clientContextParam required status from endpoint ruleset params * feat(endpoint): exclude contextParams from operation uri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.