fix: trailing comma not allowed in ruleset #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardomourar
changed the title
*Issue #, if available:* smithy-lang#633 *Description of changes:* This will generate a valid TypeScript file for `src/endpoint/ruleset.ts`.
eduardomourar
force-pushed
the
fix/trailing-comma-ruleset
branch
from
b9fa503
to
ccbb330
Compare
|
@jvschneid , could this be approved and merged, please? |
gosar
reviewed
Jan 20, 2023
There was a problem hiding this comment.
I added this comment to the issue. But looking at the code and your diff here, I can see that it would generate , and is likely a prettify step that's fixing it in AWS SDK. To showcase that more directly, and for adding some missing testing here, can we add a test that would be broken before your change and fixed with this.
...in/java/software/amazon/smithy/typescript/codegen/integration/AddDefaultsModeDependency.java
Outdated
Show resolved
Hide resolved
eduardomourar
force-pushed
the
fix/trailing-comma-ruleset
branch
from
e7678fd
to
ccbb330
Compare
kuhe
approved these changes
Jan 23, 2023
gosar
approved these changes
Jan 23, 2023
Thanks @eduardomourar! I merged your PR as I didn't want to hold up the fix and was going to work on adding tests later. Thanks for adding them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#633
Description of changes:
This will generate a valid TypeScript file for
src/endpoint/ruleset.ts.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.