EndpointsV2: Do not error without aws.api#service trait #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old error was a generic NoSuchElementException and was thrown even if a sigv4 trait was defined but service was not. Now we only throw if both are undefined and the exception explains that the traits are required. ``` No aws.auth#sigv4 or aws.api#service trait, required for Endpoint default signing name ```
2 tasks
everett1992
changed the title
srchase
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit the endpoint v2 generator will throw a generic NoSuchElementException when a service doesn't have both a aws.api#service and a aws.auth#sigv4 trait. This CR improves the error message to explain the required traits, and allows either a sigv4 or a service trait, but doesn't require both.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.