Skip code generation of data filter functions for shapes that do not contain sensitive fields (recursive) #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
kuhe
force-pushed
the
feat/data-filter
branch
4 times, most recently
from
b837e38
to
ff59244
Compare
kuhe
changed the title
trivikr
approved these changes
Mar 20, 2023
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java
Outdated
Show resolved
Hide resolved
srchase
reviewed
Mar 20, 2023
srchase
reviewed
Mar 22, 2023
| * @param model - model context for the shape, containing its related shapes. | ||
| * @return whether a sensitive field exists in the shape and its downstream shapes. | ||
| */ | ||
| public boolean findsSensitiveData(Shape shape, Model model) { |
There was a problem hiding this comment.
This method name is a little confusing. Maybe containsSensitiveData instead?
There was a problem hiding this comment.
I don't want to use contains because the subject of the method is not a container like the collections that typically use that method name. How about findsSensitiveDataIn for the phrase finder.findsSensitiveDataIn(shape)?
| * a given shape. | ||
| */ | ||
| public class SensitiveDataFinder { | ||
| private Map<Shape, Boolean> cache = new HashMap<>(); |
There was a problem hiding this comment.
How is this cache supposed to work? The public method takes in a model, which could change. I don't think this will work as expected, unless the same model is used every time.
There was a problem hiding this comment.
I changed the model to be a constructor parameter.
srchase
approved these changes
Mar 22, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a recursive check for sensitive fields before generating a sensitive data filter function.
Currently all input/output have their own function even if it does nothing. This removes the no-op functions to reduce the code size.
For diff in JSv3 as an example, see aws/aws-sdk-js-v3#4544
(first commit contains a single client for easier viewing).
~> [trait|sensitive], look forSelector.parse(suggestion from @kstich)