feat(types): codegen for improved streaming payload types #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
approved these changes
Jul 20, 2023
kuhe
force-pushed
the
feat/streaming-types-codegen
branch
4 times, most recently
from
0f3581b
to
7f216ea
Compare
srchase
approved these changes
Jul 26, 2023
| @@ -0,0 +1,36 @@ | |||
| const fs = require("node:fs"); | |||
There was a problem hiding this comment.
nit: There's no documentation on what this is for. It'd be helpful to note that it will be removed after moving to use the change in #832.
There was a problem hiding this comment.
added a reminder to that PR
kuhe
force-pushed
the
feat/streaming-types-codegen
branch
3 times, most recently
from
af6a6e4
to
e43e770
Compare
kuhe
force-pushed
the
feat/streaming-types-codegen
branch
from
e43e770
to
365f430
Compare
|
jsv3 codegen pr: aws/aws-sdk-js-v3#4987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegen changes for #835