Add matchSettings() to RuntimeClientPlugins
#856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
add-match-settings
branch
from
7335f2a
to
f6417c1
Compare
kuhe
approved these changes
Aug 4, 2023
This was referenced Aug 4, 2023
Enable `RuntimeClientPlugin`s to be filtered based on settings, and filter at the top-level of `DirectedTypeScriptCodegen`.
syall
force-pushed
the
add-match-settings
branch
from
f6417c1
to
131a09f
Compare
milesziemer
approved these changes
Aug 9, 2023
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Enable
RuntimeClientPlugins to be filtered based on settings, and filter at the top-level ofDirectedTypeScriptCodegen.See previously closed PR: #684
Testing:
./gradlew clean build checkbuilds successfullyyarn generate-clientsbuilds successfully and produces no codegen diff.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.