Fix javadoc search links #1009
Merged
Fix javadoc search links #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our javadocs are broken due to JDK bug https://bugs.openjdk.java.net/browse/JDK-8215291 which is fixed in JDK 12. We can work around it by specifying --no-module-directories when generating javadocs. fixes smithy-lang#1006
adamthom-amzn
force-pushed
the
fix-javadoc-search-links
branch
from
e379017
to
b189e9f
Compare
kstich
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1006
Description of changes:
Our javadocs are broken due to JDK bug
https://bugs.openjdk.java.net/browse/JDK-8215291 which is fixed in JDK 12.
We can work around it by specifying --no-module-directories when generating
javadocs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.