Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add malformed request tests for more set types #1094

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

adamthom-amzn
Copy link
Contributor

Description of changes:
Sets of blobs, dates and documents are all valid, and may not be easily
supported in all targeted server languages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sets of blobs, dates, structures and documents are all valid, and may not be
easily supported in all targeted server languages.
Copy link
Contributor

@david-perez david-perez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@adamthom-amzn adamthom-amzn merged commit d633e5d into smithy-lang:main Feb 17, 2022
@adamthom-amzn adamthom-amzn deleted the set-enhancemnts branch February 17, 2022 22:19
{
id: "RestJsonMalformedSetDuplicateDocuments",
documentation: """
When the set has duplicated documents, the response should be a 400
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not indent long strings to make it easier to see key value pairs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy and pasted the same mistake as the test above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants