Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial docs for TypeScript SSDK #1119

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

adamthom-amzn
Copy link
Contributor

@adamthom-amzn adamthom-amzn commented Mar 3, 2022

Intro
Handlers
Error Handling
Endpoints
Validation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adamthom-amzn adamthom-amzn requested a review from a team as a code owner March 3, 2022 19:46
@adamthom-amzn adamthom-amzn marked this pull request as draft March 3, 2022 19:47
docs/source/ts-ssdk/supported-endpoints.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/validation.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/validation.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/error-handling.rst Show resolved Hide resolved
docs/source/ts-ssdk/handlers.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/supported-endpoints.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/validation.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/validation.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/validation.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/implementations.rst Show resolved Hide resolved
docs/source/implementations.rst Outdated Show resolved Hide resolved
@@ -0,0 +1,60 @@
##########################################################
Introduction to the Smithy Server Generator for TypeScript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should we talk about how to use this codegen, i.e., something like

      "plugins": {
        "typescript-ssdk-codegen": {
          "package": "@aws-smithy/example",
          "packageVersion": "1.0.0-alpha.1"
        }

Currently this only comes up in validation section for how to disable, but seems like it should come up earlier. Some section on getting started?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a quickstart section, I'd rather have an example repository we link to. I don't have that repository yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, example repo will be good

docs/source/ts-ssdk/introduction.rst Outdated Show resolved Hide resolved
docs/source/ts-ssdk/supported-endpoints.rst Show resolved Hide resolved
Co-authored-by: Chase Coalwell <c.coalwell@gmail.com>

*Synthetic errors* are errors that are not included in the Smithy model, but can still be thrown by the server SDK. In
general, these errors are not expected to have corresponding code generated types on the client side. These errors fall
into two categories: framework-level errors that are unavoidable, and errors that are associated with the low-level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default errors from API Gateway should also have its own category as part of the Synthetic errors. With the difference that the service team will have no control over it (as explained briefly in this issue).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those would need their own section once we come up with a more specific API Gateway solution.

There are always going to be intermediaries (CDNs, caches, reverse proxies, what-have-you) that can return error responses that the server has no control over. While we have some customization options for API Gateway, generated clients should be durable to these failures, and I don't think the proper experience is customers having a modeled type for things like 502 Bad Gateway.

@adamthom-amzn adamthom-amzn marked this pull request as ready for review April 26, 2022 18:07
@adamthom-amzn adamthom-amzn merged commit 9f0774f into smithy-lang:main Apr 28, 2022
adamthom-amzn added a commit that referenced this pull request Apr 28, 2022
Add initial docs for TypeScript SSDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants