Exclude enum and intEnum from some linting #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
approved these changes
Mar 14, 2022
| // Exclude members of enums from AbbreviationName validation, | ||
| // as they're intended to be CAPS_SNAKE. | ||
| if (shape.isMemberShape()) { | ||
| Shape target = model.expectShape(shape.asMemberShape().get().getContainer()); |
There was a problem hiding this comment.
me being annoying: is target the right term for this, since it's the container?
This commit excludes linting enum and intEnum members for AbbreviationName and CamelCase checks, as they are intended to be CAPS_SNAKE.
kstich
force-pushed
the
enum_member_linter_updates
branch
from
e2f7094
to
f4503d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit excludes linting
enumandintEnummembers forAbbreviationNameand
CamelCasechecks, as they are intended to be CAPS_SNAKE.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.