Forbid using requiresLength with output #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not allow using the requiresLength trait with streaming blobs used in output shapes. We can lift this restriction in the future if a use case ever arises, but by forbidding this use case now, implementations are free to treat blobs marked with the requiresLength trait as a specialization of a stream that affects the generated type.
mtdowling
force-pushed
the
forbid-requiresLength-on-output
branch
from
b1c5554
to
50e0aa5
Compare
kstich
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does not allow using the requiresLength trait with streaming
blobs used in output shapes. We can lift this restriction in the future
if a use case ever arises, but by forbidding this use case now,
implementations are free to treat blobs marked with the requiresLength
trait as a specialization of a stream that affects the generated type.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.