Migrate remaining traits packages to use IDL definitions #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
changed the title
kstich
requested changes
Apr 26, 2022
smithy-aws-apigateway-traits/src/main/resources/META-INF/smithy/aws.apigateway.smithy
Show resolved
Hide resolved
smithy-aws-apigateway-traits/src/main/resources/META-INF/smithy/aws.apigateway.smithy
Show resolved
Hide resolved
smithy-aws-apigateway-traits/src/main/resources/META-INF/smithy/aws.apigateway.smithy
Show resolved
Hide resolved
smithy-aws-traits/src/main/resources/META-INF/smithy/aws.protocols.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/resources/META-INF/smithy/aws.protocols.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/resources/META-INF/smithy/aws.protocols.smithy
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
idl-aws-traits
branch
from
d5d7495 to
b9a24b2
Compare
This updates some of the trait definittions that were still in the AST format to the IDL.
JordonPhillips
force-pushed
the
idl-aws-traits
branch
from
b9a24b2 to
83190ba
Compare
kstich
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the remaining trait definitions from AST format to IDL format as well as fills out some missing documentation traits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.