Various IDL 2.0 fixes and tweaks #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a bit more 1.0 support to NullableIndex to account for shapes that weren't converted to Smithy 2.0 but still target a removed primitive prelude shape that implies a member is non-nullable by default.
Add a nullability resolver that uses only v1 model semantics to account for manually created models that didn't pass through the upgrade functionality of a ModelAssembler. Needing to use this method should be very rare, but adding it in case as a kind of utility method.
mtdowling
changed the title
Rather than expose a NamedMembers interface, I think it makes more sense to just move all member accessors to Shape. This gets rid of a lot of cruft when trying to deal with different kinds of shapes (for example, if you want to write something that works with both structures and unions). Furthermore, structurallyExclusive only impacts structure shapes. This fixes an issue where it was implemented to also check enums, intEnums, and unions.
mtdowling
force-pushed
the
fix-2.0-deprecations
branch
from
bd6414f to
45c42cf
Compare
kstich
requested changes
Jul 25, 2022
smithy-model/src/main/java/software/amazon/smithy/model/shapes/MapShape.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/CollectionShape.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/NamedMembersShapeBuilder.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/NamedMembersShapeBuilder.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/NullableIndex.java
Show resolved
Hide resolved
kstich
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.