Add minor perf improvements #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was doing some profiling and saw lots of string computations caused by recomputing equals and hashcode. This adds a cache for the hashCode of Shape and takes advantage of the caching used for Trait and Shape when performing equals checks. I also don't think the cost of computing a canonical class name is needed compared to using Class#getName for Model's blackboard data structure. Finally, I saw we were creating a Stream and not using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some profiling and saw lots of string
computations caused by recomputing equals and hashcode.
This adds a cache for the hashCode of Shape and takes
advantage of the caching used for Trait and Shape when
performing equals checks.
I also don't think the cost of computing a canonical
class name is needed compared to using Class#getName
for Model's blackboard data structure.
Finally, I saw we were creating a Stream and not using it.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.