Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to check if NumberNode is set to zero #1385

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Add method to check if NumberNode is set to zero #1385

merged 1 commit into from
Sep 4, 2022

Conversation

mtdowling
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mtdowling mtdowling requested a review from a team as a code owner September 4, 2022 17:14
@mtdowling mtdowling force-pushed the add-number-is-zero branch 2 times, most recently from bc0ce0a to f33edf2 Compare September 4, 2022 18:42
@mtdowling mtdowling requested a review from gosar September 4, 2022 18:43
gosar
gosar reviewed Sep 4, 2022
View reviewed changes
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it after this last change requested

smithy-model/src/main/java/software/amazon/smithy/model/node/NumberNode.java Outdated Show resolved Hide resolved
@mtdowling mtdowling merged commit 2bc09aa into main Sep 4, 2022
@mtdowling mtdowling deleted the add-number-is-zero branch October 24, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosar gosar gosar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtdowling @gosar