Add x-amz-target for missing AWS JSON 1.1 tests
#1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weihang Lo <weihanglo@users.noreply.github.com>
2 tasks
kstich
reviewed
Sep 19, 2022
There was a problem hiding this comment.
Thanks for submitting this!
There are a few more tests missing the header it looks like. One has a comment since it's in an adjusted file, there are two in endpoints.smithy and another one in endpoint-paths.smithy. Would you mind updating to add those as well?
| headers: {"Content-Type": "application/x-amz-json-1.1"}, | ||
| headers: { | ||
| "Content-Type": "application/x-amz-json-1.1", | ||
| "X-Amz-Target": "JsonProtocol.NullOperation", |
There was a problem hiding this comment.
There's a test above this that, while client specific, should have the header.
There was a problem hiding this comment.
Thank you. Updated. However, I don't have any test at hand to verify their behaviour.
kstich
approved these changes
Oct 25, 2022
david-perez
added a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Jan 4, 2023
Fixes were upstreamed in: * smithy-lang/smithy#1040, which was rolled out in Smithy v1.18, 10 months ago. * smithy-lang/smithy#1392, which was rolled out in Smithy v1.26.1, 9 weeks ago.
LukeMathWalker
pushed a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Jan 5, 2023
Fixes were upstreamed in: * smithy-lang/smithy#1040, which was rolled out in Smithy v1.18, 10 months ago. * smithy-lang/smithy#1392, which was rolled out in Smithy v1.26.1, 9 weeks ago.
aws-sdk-rust-ci
pushed a commit
to awslabs/aws-sdk-rust
that referenced
this pull request
Jan 13, 2023
Fixes were upstreamed in: * smithy-lang/smithy#1040, which was rolled out in Smithy v1.18, 10 months ago. * smithy-lang/smithy#1392, which was rolled out in Smithy v1.26.1, 9 weeks ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #1391
Description of changes: Add missing
X-Amz-Targetheader for AWS JSON 1.1 protocol@httpRequestTestslisted in #1391By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.