Enforce private on traits #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
approved these changes
Sep 20, 2022
kstich
added a commit
to kstich/smithy
that referenced
this pull request
Sep 28, 2022
This reverts commit 88e2d1f.
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
Sep 29, 2022
This reverts commit a0a76c3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1369
Description of changes:
PrivateAccessValidatorwas not checking trait relationships which allowed private traits to be referenced in any namespace. TheHttpConfigurationmixin in aws.protocols was not including private in itslocalTraits, which caused the private trait to be applied to any shape that mixed inHttpConfiguration. This issue wasn't apparent because trait relationships were not being validated for private access. The private access validation test was updated to check for this.This could be a breaking change for any Smithy models that are using private traits in other namespaces, either directly or through a mixin that doesn't have private included in its
localTraits.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.