Fix apply statement parsing and ABNF #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where `applySomeShape @someTrait` was valid, without any space between the apply and shape name. The fix makes it so spacing is required, not line breaks as was the case in the old ABNF, to be consistent with other shapes grammar (see [SimpleShapeStatement](https://awslabs.github.io/smithy/2.0/spec/idl.html#grammar-token-smithy-SimpleShapeStatement))
sugmanue
approved these changes
Sep 20, 2022
| sp(); | ||
| rsp(); |
There was a problem hiding this comment.
Too bad that the names of the methods have diverged from the name of the grammar productions, but that's not related to this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
applySomeShape @someTraitwas valid, without any space between the apply and shape name. The fix makes it so spacing is required, not line breaks as was the case in the old ABNF, to be consistent with other shapes grammar (see SimpleShapeStatement)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.