Always attempt model interop transforms #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously did not attempt to perform model interop transforms if a model had errors. For example, if a model referred to an unknown trait, the model wouldn't use the interop transformation. Some use cases might choose to ignore unknown traits and other errors by _not_ unwrapping the assembled model and instead directly accessing the result from ValidatedResult. In these cases, the model would have not gone through the interop transform, resulting in an unexpect model (for example, if performing a diff against a 1.0 and 2.0 model, the upgrade won't run and causes the models to appear to be wildly different).
syall
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did not attempt to perform model interop transforms if a model had errors. For example, if a model referred to an unknown trait, the model wouldn't use the interop transformation. Some use cases might choose to ignore unknown traits and other errors by not unwrapping the assembled model and instead directly accessing the result from ValidatedResult. In these cases, the model would have not gone through the interop transform, resulting in an unexpect model (for example, if performing a diff against a 1.0 and 2.0 model, the upgrade won't run and causes the models to appear to be wildly different).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.