Improve ChangedNullability diff evaluator #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
suggested changes
Oct 19, 2022
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/ChangedNullability.java
Outdated
Show resolved
Hide resolved
smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/ChangedNullabilityTest.java
Show resolved
Hide resolved
This validator now does not emit trait change warnings when the required trait is changed, and instead relies on ChangedNullability (this matches how the box trait is handled too). When the required trait is removed from a member that targets a structure or union, a warning is emitted instead of an error to indicate that this is often allowed in Smithy generators that treat these members as always nullable regardless of the required trait.
mtdowling
force-pushed
the
fix-changed-nullability
branch
from
6fbdee9 to
37b7e4c
Compare
syall
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validator now does not emit trait change warnings when the required trait is changed, and instead relies on ChangedNullability (this matches how the box trait is handled too). When the required trait is removed from a member that targets a structure or union, a warning is emitted instead of an error to indicate that this is often allowed in Smithy generators that treat these members as always nullable regardless of the required trait.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.