Remove pattern from suppress trait entries #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suppress trait contained a restrictive pattern trait that was not present in validator ID definitions. This meant that validation events could be suppressed in metadata suppressions (where there was no pattern validation), but not using the `@suppress` trait. Adding the pattern from the `@suppress` trait to validation event IDs at this point has the potential to break existing models, so that is not a desirable alternative. Closes #987
syall
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suppress trait contained a restrictive pattern trait that was not present in validator ID definitions. This meant that validation events could be suppressed in metadata suppressions (where there was no pattern validation), but not using the
@suppresstrait. Adding the pattern from the@suppresstrait to validation event IDs at this point has the potential to break existing models, so that is not a desirable alternative.Closes #987
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.