Move CDS warmup to the CLI directly #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
move-cds-to-cli
branch
from
2977149
to
6466b76
Compare
The Java class data sharing archive can now be created by the CLI using the warmup command. This makes it possible to build the CDS archive during an install step so that the archive uses the right paths. Creating the archive before distributing the CLI results in the archive using absolute paths pointing to the where the CLI was built rather than where it is installed on end user machines.
mtdowling
force-pushed
the
move-cds-to-cli
branch
from
6466b76
to
61c4718
Compare
srchase
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java class data sharing archive can now be created by the CLI using the warmup command. This makes it possible to build the CDS archive during an install step so that the archive uses the right paths. Creating the archive before distributing the CLI results in the archive using absolute paths pointing to the where the CLI was built rather than where it is installed on end user machines.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.