Fix parameters to builder #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
fix-parameters-to-builder
branch
from
b39d4e9
to
acae9b7
Compare
kstich
requested changes
Jan 9, 2023
...s-engine/src/test/java/software/amazon/smithy/rulesengine/language/syntax/ParameterTest.java
Show resolved
Hide resolved
kstich
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Fix two bugs in the
toBuildermethods.In
Parameter, fields were dropped.In
ClientContextParameter,toBuilderreturned an interface which made it impossible to use from calling code.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.