Add endpoint discovery traits #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to get all of the info you need about a given operation's endpoint discovery configuration.
This adds a transformer that removes the endpoint discovery trait when either the referenced operation or referenced error are removed.
JordonPhillips
changed the title
kstich
requested changes
Sep 17, 2019
...rc/main/java/software/amazon/smithy/aws/traits/endpointdiscovery/EndpointDiscoveryTrait.java
Outdated
Show resolved
Hide resolved
...ain/java/software/amazon/smithy/aws/traits/endpointdiscovery/EndpointDiscoveryValidator.java
Outdated
Show resolved
Hide resolved
...ain/java/software/amazon/smithy/aws/traits/endpointdiscovery/EndpointDiscoveryValidator.java
Outdated
Show resolved
Hide resolved
aws/smithy-aws-traits/src/main/resources/META-INF/smithy/aws.api.json
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
endpoint-discovery
branch
from
4e3ecfc to
1aeca21
Compare
kstich
reviewed
Sep 18, 2019
| /** | ||
| * Removes the endpoint discovery trait from a service if the referenced operation or error are removed. | ||
| */ | ||
| public class CleanDiscoveryTraitTransformer implements ModelTransformerPlugin { |
There was a problem hiding this comment.
The other ModelTransformerPlugin implementations handle all relevant changes to make sure the resulting model is in a valid state. Could this do so via filterTraits on the other traits? Should it?
There was a problem hiding this comment.
I think they are related but separate concerns. By decorating an operation with discoveredEndpoint you're saying that it needs to have an endpoint discovered for it to work (or at least work optimally). I don't think that changes if you project away the operation used for discovery.
This updates the endpoint discovery transformer to remove the discoveredEndpoint trait from an operation when all the services it is bound to have their endpoint discovery traits removed.
mtdowling
reviewed
Sep 19, 2019
| - a ``map`` member named ``Identifiers`` whose key and value types are | ||
| ``string`` types. | ||
|
|
||
| The operation output MUST contain a member ``Endpoints`` that is a list of |
This makes it clear that the traits are for client side discovery.
mtdowling
approved these changes
Sep 20, 2019
kstich
approved these changes
Sep 20, 2019
kstich
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds traits needed to support the endpoint discovery behavior built into AWS clients.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.