Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended AddedEntityBinding/RemovedEntityBinding event ids with granularity #1797

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Extended AddedEntityBinding/RemovedEntityBinding event ids with granularity #1797

merged 2 commits into from
Jun 8, 2023

Conversation

rchache
Copy link
Contributor

@rchache rchache commented May 30, 2023 •
edited
Loading

Issue #, if available:

Description of changes:
Extended AddedResourceBinding, AddedOperationBinding, RemovedResourceBinding, RemovedOperationBinding event ids with

  1. the type of the parent entity
  2. the id of the child shape being added/removed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchache rchache requested a review from a team as a code owner May 30, 2023 18:50
@rchache rchache changed the title Extended AddedEntityBinding event ids with granularity Extended AddedEntityBinding/RemovedEntityBinding event ids with granularity Jun 2, 2023
@rchache rchache force-pushed the rchacheAddedOperationBinding branch from 5ee2e55 to 20bf01f Compare June 3, 2023 01:11
@mtdowling mtdowling merged commit 18a7fab into smithy-lang:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtdowling mtdowling mtdowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchache @mtdowling