Update Request Compression Trait specification #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
approved these changes
Jun 20, 2023
jvschneid
approved these changes
Jun 20, 2023
syall
force-pushed
the
update-request-compression-docs
branch
from
e53ba79
to
07e1c19
Compare
added 4 commits
June 21, 2023 09:57
Fix a typo of `list<string>` to `[string]`.
Update protocol tests to test that the HTTP bindings for the `Content-Encoding` header are ignored in protocols for that do not support HTTP bindings. Also, update the protocol test descriptions to capture more information on what is the expected result.
syall
force-pushed
the
update-request-compression-docs
branch
from
07e1c19
to
5f9f553
Compare
kstich
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1827
Description of changes:
Fix typo in requestCompression trait spec.
Update request compression trait protocol tests with regard to HTTP bindings.
Also fix minor issues throughout docs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.