Remove fractional seconds from http-date #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of http-date previously stated that implementations MUST support fractional seconds. However, fractional seconds are not permitted by the imf-fixdate grammar. The original intent of this wording in the specification was that clients can gracefully handle parsing these timestamps with fractional precision, but not send fractional precision to avoid client/server incompatibilities. However, this caused confusion in implementations, and when clients send http-date timestamps with optional fractional precision, some servers, including S3, cannot parse the timestamp. To avoid these issues altogether, this commit removes any kind of specification and protocol test for handling optional fractional seconds with `http-date` timestamps.
sugmanue
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The description of http-date previously stated that implementations MUST support fractional seconds. However, fractional seconds are not permitted by the imf-fixdate grammar. The original intent of this wording in the specification was that clients can gracefully handle parsing these timestamps with fractional precision, but not send fractional precision to avoid client/server incompatibilities. However, this caused confusion in implementations, and when clients send http-date timestamps with optional fractional precision, some servers, including S3, cannot parse the timestamp.
To avoid these issues altogether, this commit removes any kind of specification and protocol test for handling optional fractional seconds with
http-datetimestamps.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.