Limit streaming traits to top level members #221
Conversation
|
Why do we need this? Ideally we could apply streaming traits to only shapes or only members. The motivation for applying only to shapes is that the streaming trait should change the code generated type of the shape. We usually try to not have members alter the type that is generated in targeted programming languages. However, an argument for the streaming trait to only be applied to members could be made based on the fact that only top-level input, output, and error shapes can every be streaming. These are actually the same locations as event streams. The rationale for making even streams apply to the member of a structure was that the structure that targets the event stream is essentially claimed as a special shape that can't be used like other shapes throughout the model.... Maybe we should apply this same treatment to the streaming trait. |
JordonPhillips
force-pushed
the
release-streaming
branch
from
b61db77 to
3b94bbc
Compare
JordonPhillips
changed the title
JordonPhillips
force-pushed
the
release-streaming
branch
from
3b94bbc to
4d51710
Compare
A streaming blob on a nested structure doesn't make much sense, so this updates the streaming trait to only apply to members of operation input/output and errors. Fundamentally this doesn't change the way that serde code would be generated, since at the end of the day simple types like blobs will never get generated types.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.