Emit warnings for deprecated traits #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Feb 19, 2020
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
...rc/test/resources/software/amazon/smithy/linters/errorfiles/deprecated-traits-validator.json
Outdated
Show resolved
Hide resolved
.../test/resources/software/amazon/smithy/linters/errorfiles/deprecated-traits-validator.errors
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
deprecated_validator
branch
from
8abdbc1 to
934de90
Compare
srchase
force-pushed
the
deprecated_validator
branch
from
934de90 to
ea47f36
Compare
mtdowling
requested changes
Feb 19, 2020
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Feb 20, 2020
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Feb 20, 2020
...rc/test/resources/software/amazon/smithy/linters/errorfiles/deprecated-traits-validator.json
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/DeprecatedTraitsValidator.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Feb 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DeprecatedTraitsValidator that emits warnings when a model contains shapes that apply deprecated traits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.