Use expect* methods more + some cleanup #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
approved these changes
Mar 13, 2020
mtdowling
force-pushed
the
use-more-expect
branch
from
eefe893
to
8b1ce45
Compare
This commit uses the expectTrait methods and hasTrait methods more instead of using .get(). This will give much more clear error messages in the event of a logical error in code. This also adds expect* methods that expect a shape to be of a specific type. This cleans up a lot of call sites that were using an unsafe .get() after calling .asBlob, asString, etc.
mtdowling
force-pushed
the
use-more-expect
branch
from
8b1ce45
to
f295785
Compare
kstich
approved these changes
Mar 16, 2020
| @@ -417,6 +417,319 @@ public boolean hasTrait(Class<? extends Trait> traitClass) { | |||
| return Optional.empty(); | |||
| } | |||
|
|
|||
| /** | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the expectTrait methods and hasTrait methods more
instead of using .get(). This will give much more clear error messages
in the event of a logical error in code.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.