Replace jackson-core with vendored minimal-json #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes our dependency on jackson-core and replaces it with a vendored and slightly modified version of minimal-json. Reducing dependencies on popular projects like Jackson make it easier to use Smithy in large, heterogenous environments like large corporate build systems. minimal-json is vendored into smithy-model to allow Nodes to be parsed and serialized from JSON documents. The major change that was added to minimal-json was to allow skipping over optional "//" line comments.
kstich
approved these changes
Mar 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes our dependency on jackson-core and replaces it with
a vendored and slightly modified version of minimal-json. Reducing
dependencies on popular projects like Jackson make it easier to use
Smithy in large, heterogenous environments like large corporate build
systems. minimal-json is vendored into smithy-model to allow Nodes to be
parsed and serialized from JSON documents. The major change that was
added to minimal-json was to allow skipping over optional "//" line
comments.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.