Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model version from 0.5.0 to 1.0.0 #357

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Apr 3, 2020

Updates Model version from 0.5.0 to 1.0.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from mtdowling April 3, 2020 00:09
Copy link
Member

@mtdowling mtdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kstich should we do 1.0 or 1.0.0? The spec currently says:

The Smithy specification is versioned using a semver major . minor . patch version string. The version string does not support semver extensions.

@kstich
Copy link
Contributor

kstich commented Apr 3, 2020

I'd say 1.0.0 is the right call, we may have the need for minor vs patch level updates in the future.

@srchase srchase changed the title Update model version from 0.5.0 to 1.0 Update model version from 0.5.0 to 1.0.0 Apr 3, 2020
@srchase srchase merged commit 3c457cf into smithy-lang:0.10 Apr 3, 2020
@srchase srchase deleted the model_version_1.0 branch April 3, 2020 18:36
JordonPhillips pushed a commit to JordonPhillips/smithy that referenced this pull request Apr 22, 2020
@kstich kstich mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants