Collapse eventstream with the streaming trait #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eventstream and streaming trait fundamentally work in similar ways, and have identical validation rules. This merges the two traits to simplify the model and reduce duplication.
mtdowling
requested changes
Apr 9, 2020
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/EventStreamIndex.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/HttpBindingIndex.java
Outdated
Show resolved
Hide resolved
...src/test/resources/software/amazon/smithy/model/errorfiles/validators/streaming-trait.errors
Show resolved
Hide resolved
...s/src/main/java/software/amazon/smithy/mqtt/traits/validators/MqttPublishInputValidator.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Apr 10, 2020
| - Description | ||
| * - requiresLength | ||
| - ``boolean`` | ||
| - Indicates that the stream must have a known size. |
There was a problem hiding this comment.
This can only be set when attached to blobs, right? Should this maybe be a separate trait to make this discrepancy less weird?
There was a problem hiding this comment.
Maybe. Is there not a use case for it for event streams?
There was a problem hiding this comment.
I doubt it. Event streams usually don't have a predefined size or bounds.
mtdowling
approved these changes
Apr 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventstream and streaming trait fundamentally work in similar
ways, and have identical validation rules. This merges the two traits
to simplify the model and reduce duplication.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.