Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title trait selector #387

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Apr 17, 2020

Fixes title trait selector to correctly allow the trait to be applied to services and resources.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from kstich April 17, 2020 20:53
@mtdowling
Copy link
Member

Sorry, this trait should appear on resources and services, not operations. I told you the wrong thing.

@srchase srchase changed the title Fix title trait documentation Fix title trait selector Apr 17, 2020
@mtdowling mtdowling merged commit b7c1020 into smithy-lang:0.10 Apr 18, 2020
@kstich kstich mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants