Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validators into core spec, rethink suppressions #397

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

mtdowling
Copy link
Member

Move validation into core

This commit moves model validation and suppressions into the core.
EmitEachSelector and EmitNoneSelector are now part of smithy-model and
were removed from smithy-linters. The `@suppress` trait was added to
suppress validaation events on specific shapes. The `validators`
metadata property was updated so that it now only take `id`,
`namespace`, and `reason`, where `namespace` can be set to `*` to
suppress a validation event for all namespaces or validation events that
aren't specific to a single shape.

The ability to add custom suppressions to the ModeAssembler has been
removed.

Move validation into core spec

This commit moves validation concepts into the core Smithy spec while
leaving more specific linters in a linters guide.

This commit moves model validation and suppressions into the core.
EmitEachSelector and EmitNoneSelector are now part of smithy-model and
were removed from smithy-linters. The `@suppress` trait was added to
suppress validaation events on specific shapes. The `validators`
metadata property was updated so that it now only take `id`,
`namespace`, and `reason`, where `namespace` can be set to `*` to
suppress a validation event for all namespaces or validation events that
aren't specific to a single shape.

The ability to add custom suppressions to the ModeAssembler has been
removed.
@mtdowling mtdowling requested a review from kstich April 23, 2020 23:40
This commit moves validation concepts into the core Smithy spec while
leaving more specific linters in a linters guide.
@mtdowling mtdowling force-pushed the rethink-validators branch from 07a5c82 to 1c92a0d Compare April 24, 2020 16:47
@mtdowling mtdowling requested a review from kstich April 24, 2020 16:47
@mtdowling mtdowling merged commit 93b58e1 into 1.0 Apr 24, 2020
@mtdowling mtdowling deleted the rethink-validators branch April 27, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants