Remove abbreviation from aws.api#service docs #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abbreviation property in aws.api#service was not actually supported by the underlying Smithy model for the trait. We intended to remove this from Smithy 1.0, but it was a miss. The abbreviation property is no longer necessary since we now have the service ID property via sdkId. The abbreviation property was also problematic since lots of entries across services didn't make sense (like a value longer than the title). Trying to define an abbreviation will emit a warning but will not break builds (this is actually the current behavior too since it wasn't defined in the model).
srchase
approved these changes
Aug 19, 2020
JordonPhillips
requested changes
Aug 19, 2020
JordonPhillips
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abbreviation property in aws.api#service was not actually supported
by the underlying Smithy model for the trait. We intended to remove this
from Smithy 1.0, but it was a miss. The abbreviation property is no
longer necessary since we now have the service ID property via sdkId.
The abbreviation property was also problematic since lots of entries
across services didn't make sense (like a value longer than the title).
Trying to define an abbreviation will emit a warning but will not break
builds (this is actually the current behavior too since it wasn't
defined in the model).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.