Add reverse-topological index #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some languages require types to be defined before they're referenced, so they need a reverse topological ordering of shapes. They also need to know which shapes are recursive so that they can use forward declarations before referencing recursive types. This commit adds a TopologicalIndex to smithy-codegen-core to provide a stable ordered reverse-topological set of shapes, and a set of recursive shapes along with their recursive closures. This recursive closure may also be of interest to code generators when deciding whether or not a recursive reference needs to be boxed or not to compute a type's size at compile time.
mtdowling
force-pushed
the
topological-sort
branch
from
646c39a
to
8279f54
Compare
smithy-codegen-core/src/main/java/software/amazon/smithy/codegen/core/TopologicalIndex.java
Show resolved
Hide resolved
JordonPhillips
approved these changes
Aug 28, 2020
JordonPhillips
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages require types to be defined before they're referenced, so
they need a reverse topological ordering of shapes. They also need to
know which shapes are recursive so that they can use forward
declarations before referencing recursive types. This commit adds a
TopologicalIndex to smithy-codegen-core to provide a stable ordered
reverse-topological set of shapes, and a set of recursive shapes along
with their recursive closures. This recursive closure may also be of
interest to code generators when deciding whether or not a recursive
reference needs to be boxed or not to compute a type's size at compile
time.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.